[webkit-reviews] review granted: [Bug 190720] [LFC][IFC] RenderReplaced renderer should create InlineBox : [Attachment 352700] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 190720: [LFC][IFC] RenderReplaced renderer should create InlineBox
https://bugs.webkit.org/show_bug.cgi?id=190720

Attachment 352700: Patch

https://bugs.webkit.org/attachment.cgi?id=352700&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 352700
  --> https://bugs.webkit.org/attachment.cgi?id=352700
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352700&action=review

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:91
> +	       box = new InlineBox( { },
RenderStyle::createAnonymousStyleWithDisplay(rootRenderer.style(),
DisplayType::Inline));

Using new is lame. Can we use unique_ptrs and make_unique for safe memory
management here?