[webkit-reviews] review granted: [Bug 190696] [LFC][IFC] Add generic inline run generator. : [Attachment 352679] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 190696: [LFC][IFC] Add generic inline run generator.
https://bugs.webkit.org/show_bug.cgi?id=190696

Attachment 352679: Patch

https://bugs.webkit.org/attachment.cgi?id=352679&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 352679
  --> https://bugs.webkit.org/attachment.cgi?id=352679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352679&action=review

> Source/WebCore/layout/inlineformatting/InlineRunProvider.h:100
> +	   Run(const InlineItem&, Type);
> +	   Run(const InlineItem&, Type, TextContext);

Could just take std::optional<TextContext> and combine these.

> Source/WebCore/layout/inlineformatting/InlineRunProvider.h:108
> +    using Runs = Vector<InlineRunProvider::Run>;
> +
> +    const Runs& runs() const { return m_inlineRuns; }

Just using Vector<InlineRunProvider::Run> might be clearer an alias.

> Source/WebCore/layout/layouttree/LayoutInlineBox.cpp:39
> +InlineBox::InlineBox(std::optional<ElementAttributes> attributes,
RenderStyle&& style, BaseTypeFlags baseTypeFlags)

BaseTypeFlags stuff should really be using OptionSet these days.