[webkit-reviews] review granted: [Bug 190738] [EME] Fix crash during tracing in gst_qtdemux_request_protection_context : [Attachment 352781] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 190738: [EME] Fix crash during tracing in 
gst_qtdemux_request_protection_context
https://bugs.webkit.org/show_bug.cgi?id=190738

Attachment 352781: Patch

https://bugs.webkit.org/attachment.cgi?id=352781&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 352781
  --> https://bugs.webkit.org/attachment.cgi?id=352781
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352781&action=review

>
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/encrypted-media/resour
ces/clearkey-retrieve-destroy-persistent-license-expected.txt:10
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x120
> +  RenderBlock {HTML} at (0,0) size 800x120
> +    RenderBody {BODY} at (8,8) size 784x104
> +	 RenderBlock {DIV} at (0,0) size 784x0
> +	 RenderBlock {DIV} at (0,0) size 784x104
> +	   RenderText {#text} at (0,0) size 0x0
> +layer at (8,8) size 200x100
> +  RenderVideo {VIDEO} at (0,0) size 200x100

why are we getting the tree dump here?

>
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/encrypted-media/resour
ces/clearkey-retrieve-persistent-license-expected.txt:10
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x120
> +  RenderBlock {HTML} at (0,0) size 800x120
> +    RenderBody {BODY} at (8,8) size 784x104
> +	 RenderBlock {DIV} at (0,0) size 784x0
> +	 RenderBlock {DIV} at (0,0) size 784x104
> +	   RenderText {#text} at (0,0) size 0x0
> +layer at (8,8) size 200x100
> +  RenderVideo {VIDEO} at (0,0) size 200x100

ditto