[webkit-reviews] review granted: [Bug 186176] [BigInt] Add ValueSub into DFG : [Attachment 352768] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 186176: [BigInt] Add ValueSub into DFG
https://bugs.webkit.org/show_bug.cgi?id=186176

Attachment 352768: Patch

https://bugs.webkit.org/attachment.cgi?id=352768&action=review




--- Comment #22 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 352768
  --> https://bugs.webkit.org/attachment.cgi?id=352768
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352768&action=review

r=me

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:120
> +		   // FIXME: [DFG] Clear ArithSub when ArithMode is Unchecked
> +		   // https://bugs.webkit.org/show_bug.cgi?id=190607

Ditto.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:327
> +	       // FIXME: [DFG] Clear ArithSub when ArithMode is Unchecked

Fix the description to "Clear ArithSub's NodeMustGenerate when ArithMode is
unchecked". And `[DFG]` is not necessary.