[webkit-reviews] review granted: [Bug 190514] [Win][Clang] Do not give -Wall to clang-cl because it is treated as -Weverything : [Attachment 352687] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 190514: [Win][Clang] Do not give -Wall to clang-cl because it is treated as
-Weverything
https://bugs.webkit.org/show_bug.cgi?id=190514

Attachment 352687: Patch

https://bugs.webkit.org/attachment.cgi?id=352687&action=review




--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 352687
  --> https://bugs.webkit.org/attachment.cgi?id=352687
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352687&action=review

> Source/cmake/WebKitCompilerFlags.cmake:148
> +if (NOT MSVC)

What about:

if (COMPILER_IS_GCC_OR_CLANG AND NOT MSVC)

It's just unfriendly to pass GCC flags to random compilers that might not be
GCC compatible (even if it's unlikely that somebody would be attempting to use
such a compiler nowadays.)