[webkit-reviews] review granted: [Bug 190740] vmCall should check if we exit before emitting an OSR exit due to exceptions : [Attachment 352747] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 190740: vmCall should check if we exit before emitting an OSR exit due to
exceptions
https://bugs.webkit.org/show_bug.cgi?id=190740

Attachment 352747: patch

https://bugs.webkit.org/attachment.cgi?id=352747&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 352747
  --> https://bugs.webkit.org/attachment.cgi?id=352747
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352747&action=review

r=me

> Source/JavaScriptCore/ChangeLog:21
> +	   emitting an exception check. A node node being able to exit implies

I think you meant to say "A node not being able"

> Source/JavaScriptCore/ChangeLog:22
> +	   that it can't exit for exceptions (hence, it can't throw an
exception).

I suggest saying "it also can't".