[webkit-reviews] review granted: [Bug 190638] Safari is not able to adapt between H264 streams with EditList and without EditList : [Attachment 352706] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 190638: Safari is not able to adapt between H264 streams with EditList and
without EditList
https://bugs.webkit.org/show_bug.cgi?id=190638

Attachment 352706: Patch

https://bugs.webkit.org/attachment.cgi?id=352706&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 352706
  --> https://bugs.webkit.org/attachment.cgi?id=352706
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352706&action=review

> Source/WebCore/Modules/mediasource/SampleMap.cpp:316
> +    // endKey is not inclusive, so use lower_bound to exclude samples which
start exactly at endKey.

Nit: don't you mean "... so use upper_bound to ..."

> LayoutTests/media/media-source/media-source-append-overlapping-dts.html:4
> +    <title>mock-media-source</title>

Nit: a more descriptive title would be nice.