[webkit-reviews] review granted: [Bug 190732] clean-webkit pulls in many unnecessary dependencies in webkitpy : [Attachment 352732] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 14:20:51 PDT 2018


Alexey Proskuryakov <ap at webkit.org> has granted Dean Johnson
<dean_johnson at apple.com>'s request for review:
Bug 190732: clean-webkit pulls in many unnecessary dependencies in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=190732

Attachment 352732: Patch

https://bugs.webkit.org/attachment.cgi?id=352732&action=review




--- Comment #6 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 352732
  --> https://bugs.webkit.org/attachment.cgi?id=352732
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352732&action=review

> Tools/Scripts/webkitpy/common/host.py:58
> +    @property

Do we need @property here? Looks like @memoized tends to be used without.


More information about the webkit-reviews mailing list