[webkit-reviews] review denied: [Bug 190687] Only cap lifetime of persistent cookies created client-side through document.cookie when resource load statistics is enabled : [Attachment 352654] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 08:54:17 PDT 2018


Chris Dumez <cdumez at apple.com> has denied John Wilander <wilander at apple.com>'s
request for review:
Bug 190687: Only cap lifetime of persistent cookies created client-side through
document.cookie when resource load statistics is enabled
https://bugs.webkit.org/show_bug.cgi?id=190687

Attachment 352654: Patch

https://bugs.webkit.org/attachment.cgi?id=352654&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 352654
  --> https://bugs.webkit.org/attachment.cgi?id=352654
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352654&action=review

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:213
> +	   if (m_networkProcessCreated)

Which network process? The current models is that a single WebsiteDataStore /
WebResourceLoadStatisticsStore can be associated with several WebProcessPools
and thus several network processes.
As a result, this design relying on a single m_networkProcessCreated flag does
not seem to make much sense.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1273
> +    for (auto& processPool : processPools()) {

See how you're iterating over several process pools here? That's right since a
single WebsiteDataStore can be associated with several process pools.


More information about the webkit-reviews mailing list