[webkit-reviews] review granted: [Bug 190694] AI does not clear Phantom allocation nodes. : [Attachment 352667] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 17 17:41:51 PDT 2018


Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 190694: AI does not clear Phantom allocation nodes.
https://bugs.webkit.org/show_bug.cgi?id=190694

Attachment 352667: Patch

https://bugs.webkit.org/attachment.cgi?id=352667&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 352667
  --> https://bugs.webkit.org/attachment.cgi?id=352667
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352667&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2578
>	   // This claims to return bottom.

nit: IMO We don't really need this comment anymore since it just says exactly
what the code is doing.


More information about the webkit-reviews mailing list