[webkit-reviews] review granted: [Bug 190671] The parser should not emit a ApplyFunctionCallDotNode for Reflect.apply. : [Attachment 352635] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 190671: The parser should not emit a ApplyFunctionCallDotNode for
Reflect.apply.
https://bugs.webkit.org/show_bug.cgi?id=190671

Attachment 352635: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=352635&action=review




--- Comment #13 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 352635
  --> https://bugs.webkit.org/attachment.cgi?id=352635
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=352635&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   https://bugs.webkit.org/show_bug.cgi?id=190668).  Hence, it's a
waste of time to
> +	   emit the ApplyFunctionCallDotNode since the function check against
Function.apply

What you're doing is a heuristic, FWIW. I agree with your change, because it's
probably better, but it's still a heuristic. A user could write code where this
new heuristic is worse:
```
function Reflect() { ... }
Reflect.apply
```