[webkit-reviews] review granted: [Bug 190657] Parse paint() and store paint callbacks for CSS Painting API : [Attachment 352652] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 190657: Parse paint() and store paint callbacks for CSS Painting API
https://bugs.webkit.org/show_bug.cgi?id=190657

Attachment 352652: Patch

https://bugs.webkit.org/attachment.cgi?id=352652&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 352652
  --> https://bugs.webkit.org/attachment.cgi?id=352652
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352652&action=review

> Source/WebCore/css/CSSImageGeneratorValue.cpp:155
> +	   return nullptr;

Not essential, but it seems you'll need to implement image() isFixedSize()
fixedSize() isPending() and knownToBeOpaque() anyway, so maybe you should do
that now with stubs?

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1294
> +    // FIXME: should parse arguments

Nit: .

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1296
> +    while (!args.atEnd())
> +	   args.consume();

Should you return nullptr if there are arguments for now? I guess not.

> Source/WebCore/platform/mediastream/mac/RealtimeVideoUtilities.h:27
> +#pragma once
> +

Wow :)