[webkit-reviews] review granted: [Bug 190594] Enable the datalist element by default on iOS and macOS : [Attachment 352643] Fix double ChangeLog

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 190594: Enable the datalist element by default on iOS and macOS
https://bugs.webkit.org/show_bug.cgi?id=190594

Attachment 352643: Fix double ChangeLog

https://bugs.webkit.org/attachment.cgi?id=352643&action=review




--- Comment #34 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 352643
  --> https://bugs.webkit.org/attachment.cgi?id=352643
Fix double ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=352643&action=review

> Source/WebCore/rendering/RenderTheme.h:104
> +#if ENABLE(DATALIST_ELEMENT)
> +    virtual String dataListStyleSheet() const { return { }; }
> +#endif
> +#if ENABLE(INPUT_TYPE_COLOR)
> +    virtual String colorInputStyleSheet() const { return { }; }
> +#endif

This would break non-Apple ports. I don't think we should do that.
Either make Mac one the default style, or do a pre-processor in html.css which
special-cases iOS code.

> Source/WebCore/rendering/RenderThemeIOS.mm:1356
> +   
ASSERT(RuntimeEnabledFeatures::sharedFeatures().inputTypeColorEnabled());
> +    return "input[type=\"color\"] { width: 44px; height: 23px; outline:
none; }"_s;

Do we really need to do this in .mm files?
Can't we just use the pre-processor in html.css?