[webkit-reviews] review granted: [Bug 190653] [WebGPU] Implement WebGPU bindings up through WebGPUDevice creation : [Attachment 352631] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 17 13:38:45 PDT 2018


Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 190653: [WebGPU] Implement WebGPU bindings up through WebGPUDevice creation
https://bugs.webkit.org/show_bug.cgi?id=190653

Attachment 352631: Patch

https://bugs.webkit.org/attachment.cgi?id=352631&action=review




--- Comment #9 from Dean Jackson <dino at apple.com> ---
Comment on attachment 352631
  --> https://bugs.webkit.org/attachment.cgi?id=352631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352631&action=review

> Source/WebCore/Modules/webgpu/WebGPUAdapter.cpp:45
> +    UNUSED_PARAM(m_descriptor);

Remove.

> Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:41
> +    UNUSED_PARAM(m_adapter);

Remove.


More information about the webkit-reviews mailing list