[webkit-reviews] review granted: [Bug 186176] [BigInt] Add ValueSub into DFG : [Attachment 352395] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 186176: [BigInt] Add ValueSub into DFG
https://bugs.webkit.org/show_bug.cgi?id=186176

Attachment 352395: Patch

https://bugs.webkit.org/attachment.cgi?id=352395&action=review




--- Comment #13 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 352395
  --> https://bugs.webkit.org/attachment.cgi?id=352395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352395&action=review

r=me with nit.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:595
> +	   ASSERT(node->binaryUseKind() == UntypedUse || node->binaryUseKind()
== BigIntUse);

Let's use DFG_ASSERT.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:125
> +	      
ASSERT(Node::shouldSpeculateNumberOrBooleanExpectingDefined(child1.node(),
child2.node()));

Let's use DFG_ASSERT.