[webkit-reviews] review granted: [Bug 190651] Regression(r236795) Check boxes are sometimes checked when they should not be : [Attachment 352515] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 190651: Regression(r236795) Check boxes are sometimes checked when they
should not be
https://bugs.webkit.org/show_bug.cgi?id=190651

Attachment 352515: Patch

https://bugs.webkit.org/attachment.cgi?id=352515&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 352515
  --> https://bugs.webkit.org/attachment.cgi?id=352515
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352515&action=review

> LayoutTests/ChangeLog:12
> +	   *
fast/dom/HTMLInputElement/checkbox-dirty-checkedness-flag-expected.txt: Added.
> +	   * fast/dom/HTMLInputElement/checkbox-dirty-checkedness-flag.html:
Added.

Maybe we should add another test which sets the dirty checked flag true and
mutates attributes if there is not a test like that already.

> LayoutTests/fast/dom/HTMLInputElement/checkbox-dirty-checkedness-flag.html:7
> +description("Tests that setting the 'checked' attribute does not set its
dirty checkedness flag.");

say 'checked' content attribute to distinguish it from IDL attribute?