[webkit-reviews] review granted: [Bug 190603] Support RTCConfiguration.certificates : [Attachment 352393] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 190603: Support RTCConfiguration.certificates
https://bugs.webkit.org/show_bug.cgi?id=190603

Attachment 352393: Patch

https://bugs.webkit.org/attachment.cgi?id=352393&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 352393
  --> https://bugs.webkit.org/attachment.cgi?id=352393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352393&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:303
> +	       exception = Exception { InvalidAccessError, "Certificate is
expired"_s };

Nit: "Certificate has expired" would be better.

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:324
>	   return Exception { InvalidAccessError, "Bad Configuration
Parameters" };

Nit: maybe "Invalid configuration parameters"?