[webkit-reviews] review denied: [Bug 190245] [WPE] Text incorrectly rendered when using SimpleLineLayout : [Attachment 351871] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has denied Miguel Gomez <magomez at igalia.com>'s request
for review:
Bug 190245: [WPE] Text incorrectly rendered when using SimpleLineLayout
https://bugs.webkit.org/show_bug.cgi?id=190245

Attachment 351871: Patch

https://bugs.webkit.org/attachment.cgi?id=351871&action=review




--- Comment #7 from zalan <zalan at apple.com> ---
Comment on attachment 351871
  --> https://bugs.webkit.org/attachment.cgi?id=351871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351871&action=review

> Source/WebCore/rendering/RenderLayer.cpp:-6098
> -	       if (renderText.linesBoundingBox().isEmpty())
> -		   continue;

The bounding box value is totally invalid here and we should not make any
painting decision based on that. We end up using the value from the previous
layout which could be very different from what we might get as the result of
the style/content change.
This function should either not be called when the tree is dirty (Simon?) or
skip geometry checks on dirty renderers completely.