[webkit-reviews] review granted: [Bug 190273] Support arm64 CPUs with a 32-bit address space in the LLInt : [Attachment 352428] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 15 21:05:44 PDT 2018
Michael Saboff <msaboff at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 190273: Support arm64 CPUs with a 32-bit address space in the LLInt
https://bugs.webkit.org/show_bug.cgi?id=190273
Attachment 352428: Patch
https://bugs.webkit.org/attachment.cgi?id=352428&action=review
--- Comment #5 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 352428
--> https://bugs.webkit.org/attachment.cgi?id=352428
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=352428&action=review
r=me with a few questions.
> Source/JavaScriptCore/interpreter/CallFrame.h:73
> + alignas(CPURegister) CallFrame* callerFrame;
> + alignas(CPURegister) Instruction* returnPC;
Make this camel case: alignAs()
> Source/JavaScriptCore/offlineasm/arm64.rb:83
> + when :word
Hmm. Not sure I like full register kind to be "word". How about "reg", "full"
or "fullReg"?
More information about the webkit-reviews
mailing list