[webkit-reviews] review denied: [Bug 156271] Web Inspector: CSS autocomplete: suggestion hint should be the most commonly used property and not the alphabetically first one : [Attachment 352014] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 15:35:29 PDT 2018


Nikita Vasilyev <nvasilyev at apple.com> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 156271: Web Inspector: CSS autocomplete: suggestion hint should be the most
commonly used property and not the alphabetically first one
https://bugs.webkit.org/show_bug.cgi?id=156271

Attachment 352014: Patch

https://bugs.webkit.org/attachment.cgi?id=352014&action=review




--- Comment #9 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 352014
  --> https://bugs.webkit.org/attachment.cgi?id=352014
Patch

r- because suggestion hint (the gray text right after the text caret) is never
shown with this patch. I showed it to Devin offline.

I'm going to run with this patch for a few days to see if the autocomplete
actually selects what I want.


More information about the webkit-reviews mailing list