[webkit-reviews] review granted: [Bug 190369] [WebVTT] Support inline WebVTT styles : [Attachment 352345] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 190369: [WebVTT] Support inline WebVTT styles
https://bugs.webkit.org/show_bug.cgi?id=190369

Attachment 352345: Patch

https://bugs.webkit.org/attachment.cgi?id=352345&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 352345
  --> https://bugs.webkit.org/attachment.cgi?id=352345
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352345&action=review

> Source/WebCore/html/track/WebVTTParser.h:176
> +    ParseState collectStyleSheet(const String& line);

Nit: "line" isn't necessary.

> Source/WebCore/loader/TextTrackLoader.h:75
> +    void newStyleSheetsParsed() override;

Nit: override -> final