[webkit-reviews] review denied: [Bug 190591] Remove StorageProcess leftover : [Attachment 352359] Remove StorageProcess leftovers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 13:12:19 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has denied Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 190591: Remove StorageProcess leftover
https://bugs.webkit.org/show_bug.cgi?id=190591

Attachment 352359: Remove StorageProcess leftovers

https://bugs.webkit.org/attachment.cgi?id=352359&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 352359
  --> https://bugs.webkit.org/attachment.cgi?id=352359
Remove StorageProcess leftovers

Missing ChangeLog

Also not sure why, because you clearly removed the enum value, but mac-32bit is
unhappy for some reason:

In file included from
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sou
rces/UnifiedSource11-mm.mm:3:
/Volumes/Data/EWS/WebKit/Source/WebKit/Shared/mac/ChildProcessMac.mm:279:13:
error: enumeration value 'Storage' not handled in switch [-Werror,-Wswitch]
    switch (processType) {
	    ^
/Volumes/Data/EWS/WebKit/Source/WebKit/Shared/mac/ChildProcessMac.mm:279:13:
note: add missing switch cases
    switch (processType) {
	    ^
1 error generated.


More information about the webkit-reviews mailing list