[webkit-reviews] review denied: [Bug 190454] Add an SPI to allow WebView clients to add additional supported image formats : [Attachment 352302] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 190454: Add an SPI to allow WebView clients to add additional supported
image formats
https://bugs.webkit.org/show_bug.cgi?id=190454

Attachment 352302: Patch

https://bugs.webkit.org/attachment.cgi?id=352302&action=review




--- Comment #16 from Tim Horton <thorton at apple.com> ---
Comment on attachment 352302
  --> https://bugs.webkit.org/attachment.cgi?id=352302
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352302&action=review

We talked about how to get rid of all the preference code.

> Source/WebKit/Platform/mac/StringUtilities.mm:90
> +    [nsStringArray enumerateObjectsUsingBlock:[&] (NSString *nsString,
NSUInteger, BOOL *) {
> +	   stringList.append(String(nsString));
> +    }];

Why not just:

for (NSString *string in nsStringArray)
    strings.append(string);

And get rid of StringList.

You probably also want uncheckedAppend/reserveInitialCapacity.

You might even be able to find one of these somewhere already.