[webkit-reviews] review granted: [Bug 190528] Web Inspector: sequences of spaces longer than 16 don't show a dot : [Attachment 352245] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 09:59:42 PDT 2018


Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 190528: Web Inspector: sequences of spaces longer than 16 don't show a dot
https://bugs.webkit.org/show_bug.cgi?id=190528

Attachment 352245: Patch

https://bugs.webkit.org/attachment.cgi?id=352245&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 352245
  --> https://bugs.webkit.org/attachment.cgi?id=352245
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352245&action=review

r=me, nice cleanup!

> Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js:369
> +			   styleText += `content:
"${"\\00B7".repeat(count)}";`;

Nit: I think '\\00B7' would make this a little easier to read, since the
"outer" double-quotes are part of the string, and the "inner" double-quotes are
part of the expression.


More information about the webkit-reviews mailing list