[webkit-reviews] review granted: [Bug 190471] [GStreamer] Fix EME build for GStreamer 1.14.x : [Attachment 352177] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 190471: [GStreamer] Fix EME build for GStreamer 1.14.x
https://bugs.webkit.org/show_bug.cgi?id=190471

Attachment 352177: Patch

https://bugs.webkit.org/attachment.cgi?id=352177&action=review




--- Comment #8 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 352177
  --> https://bugs.webkit.org/attachment.cgi?id=352177
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352177&action=review

>>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1305
>> +	    if (eventKeySystemUUID == GST_PROTECTION_UNSPECIFIED_SYSTEM_ID)
> 
> I know this patch doesn't change the semantics but the assumption that
`GST_PROTECTION_UNSPECIFIED_SYSTEM_ID` implies `webm` sounds dangerous/not
future proof.

I agree and I already commented it on the original bug. I'll buy it for the
moment as in cenc the sys id is mandatory and we only suppory either webm or
cenc.