[webkit-reviews] review granted: [Bug 190560] [Apple Pay] New shipping methods are ignored when updating after the shippingaddresschange event : [Attachment 352274] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 190560: [Apple Pay] New shipping methods are ignored when updating after
the shippingaddresschange event
https://bugs.webkit.org/show_bug.cgi?id=190560

Attachment 352274: Patch

https://bugs.webkit.org/attachment.cgi?id=352274&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 352274
  --> https://bugs.webkit.org/attachment.cgi?id=352274
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352274&action=review

> Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:266
> +    }

I guess there is some existing code that extracts shipping methods from
shipping options.
Would it be worth to share the code?

> Source/WebCore/testing/MockPaymentCoordinator.cpp:115
> +    return applePayShippingMethods;

Maybe WTF::map if you like it.