[webkit-reviews] review granted: [Bug 190540] Shrink more enum classes : [Attachment 352224] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 190540: Shrink more enum classes
https://bugs.webkit.org/show_bug.cgi?id=190540

Attachment 352224: Patch

https://bugs.webkit.org/attachment.cgi?id=352224&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 352224
  --> https://bugs.webkit.org/attachment.cgi?id=352224
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352224&action=review

r=me with comment.

> Source/WebCore/loader/ShouldSkipSafeBrowsingCheck.h:32
> +enum class ShouldSkipSafeBrowsingCheck : uint8_t { No, Yes };

Why aren't we using : bool here?

> Source/WebCore/loader/ShouldTreatAsContinuingLoad.h:32
> +enum class ShouldTreatAsContinuingLoad : uint8_t { No, Yes };

ditto.

> Source/WebCore/page/DiagnosticLoggingClient.h:35
> +enum class ShouldSample : uint8_t { No, Yes };

ditto.

> Source/WebCore/platform/CookiesStrategy.h:40
> +enum class IncludeSecureCookies : uint8_t { No, Yes };

ditto.

> Source/WebCore/platform/network/StoredCredentialsPolicy.h:30
> +enum class StoredCredentialsPolicy : uint8_t {

ditto.

> Source/WebCore/workers/service/ServiceWorkerTypes.h:63
> +enum class ShouldNotifyWhenResolved : uint8_t { No, Yes };

ditto.

> Source/WebKit/Shared/UndoOrRedo.h:32
> +enum class UndoOrRedo : uint8_t { Undo, Redo };

ditto.

> Source/WebKit/WebProcess/UserContent/InjectUserScriptImmediately.h:32
> +enum class InjectUserScriptImmediately : uint8_t { No, Yes };

ditto.