[webkit-reviews] review granted: [Bug 190509] Add WebGPU 2018 feature flag and experimental feature flag : [Attachment 352220] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 190509: Add WebGPU 2018 feature flag and experimental feature flag
https://bugs.webkit.org/show_bug.cgi?id=190509

Attachment 352220: Patch

https://bugs.webkit.org/attachment.cgi?id=352220&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 352220
  --> https://bugs.webkit.org/attachment.cgi?id=352220
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352220&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1245
> +  humanReadableDescription: "WebGPU 2018 prototype"

How about WebGPU Sketch Prototype?

> Tools/DumpRenderTree/TestOptions.cpp:111
> +	   else if (key == "enableWebGPU")
> +	       enableWebGPU = parseBooleanTestHeaderValue(value);

This should be experimental:WebGPUEnabled so that it matches what WKTR is
looking for.

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:480
> +void TestRunner::setWebGPUEnabled(bool enabled)
> +{
> +    WKRetainPtr<WKStringRef> key(AdoptWK,
WKStringCreateWithUTF8CString("WebKitWebGPUEnabled"));
> +    auto& injectedBundle = InjectedBundle::singleton();
> +    WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(),
injectedBundle.pageGroup(), key.get(), enabled);
> +}

I don't think you need this any more.

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:107
> +    void setWebGPUEnabled(bool);

Or this.

> ChangeLog:13
> +	   * Source/cmake/OptionsMac.cmake:
> +	   * Source/cmake/tools/vsprops/FeatureDefines.props:
> +	   * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Technically here you were adding the Metal stuff back in :)