[webkit-reviews] review granted: [Bug 190537] [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS : [Attachment 352204] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 190537: [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
https://bugs.webkit.org/show_bug.cgi?id=190537

Attachment 352204: Patch

https://bugs.webkit.org/attachment.cgi?id=352204&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 352204
  --> https://bugs.webkit.org/attachment.cgi?id=352204
Patch

The patch looks good.

I’m not so sure about the idea of passing options via environment. The port
object is supposed to implement the knowledge of how to run tools, and passing
arguments verbatim violates incapsulation. 

Why was this approach chosen?