[webkit-reviews] review denied: [Bug 190509] Add WebGPU 2018 feature flag and experimental feature flag : [Attachment 352128] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has denied Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 190509: Add WebGPU 2018 feature flag and experimental feature flag
https://bugs.webkit.org/show_bug.cgi?id=190509

Attachment 352128: Patch

https://bugs.webkit.org/attachment.cgi?id=352128&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 352128
  --> https://bugs.webkit.org/attachment.cgi?id=352128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352128&action=review

> Source/WebCore/ChangeLog:9
> +	   Re-add ENABLE_WEBGPU, an experimental feature flag, a
RuntimeEnabledFeature,
> +	   and an InternalSetting for the 2018 WebGPU prototype.

Instead of InternalSettings, you should make a category: experimental feature
in Source/WebKit/Shared/WebPreferences.yaml. As long as it has webcoreBinding:
RuntimeEnabledFeatures then it will automatically talk to WebCore.

> Source/WebCore/ChangeLog:20
> +	   * testing/InternalSettings.cpp:
> +	   (WebCore::InternalSettings::Backup::Backup):
> +	   (WebCore::InternalSettings::Backup::restoreTo):
> +	   (WebCore::InternalSettings::setWebGPUEnabled):
> +	   * testing/InternalSettings.h:
> +	   * testing/InternalSettings.idl:

I don't think we need the flags in InternalSettings. Instead, we should use the
WebKit preference to toggle WebGPU on or off (using the <!-- webkit-test-runner
--> header). I don't see a reason to toggle it during a test.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:857
> +    [preferences setWebGPUEnabled:YES];

Similar to InternalSettings, I think the better way to do this would be to look
for the header in the test file. At the moment in WK1/DRT this is a bit of a
hack, but you can copy the logic for
experimental:WebAnimationsCSSIntegrationEnabled (just search for that in the
project and it will show you what to do). Thankfully, WK2/WKTR gets this
automatically.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:499
> +    m_testRunner->setWebGPUEnabled(true);

You can then remove this. We'll enable WebGPU via the header in the test files.