[webkit-reviews] review granted: [Bug 190504] [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view : [Attachment 352136] Fix WPE/GTK builds

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 190504: [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and
scale to fit the view
https://bugs.webkit.org/show_bug.cgi?id=190504

Attachment 352136: Fix WPE/GTK builds

https://bugs.webkit.org/attachment.cgi?id=352136&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 352136
  --> https://bugs.webkit.org/attachment.cgi?id=352136
Fix WPE/GTK builds

View in context: https://bugs.webkit.org/attachment.cgi?id=352136&action=review

> Source/WebCore/page/ViewportConfiguration.cpp:434
> +    m_configuration.initialScale *= m_layoutSizeScaleFactor;

Hi-larious

> Source/WebCore/page/ViewportConfiguration.cpp:549
> +    ts.dumpProperty("initialScaleIgnoringLayoutScaleFactor",
parameters.initialScaleIgnoringLayoutScaleFactor);

Probably also print out m_layoutSizeScaleFactor??

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:5166
>      if (viewScale <= 0 || isnan(viewScale) || isinf(viewScale))
>	   [NSException raise:NSInvalidArgumentException format:@"View scale
should be a positive number"];

Why is this in the !PLATFORM(MAC) section

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:180
> + at property (nonatomic, setter=_setViewScale:) CGFloat _viewScale
WK_API_AVAILABLE(macosx(10.11), ios(9.0));

Whoops

> Tools/ChangeLog:22
> +	   Add a new file for UIScriptController methods on Cocoa platforms.

Noice. There's some other stuff we can move here.