[webkit-reviews] review canceled: [Bug 190438] Implement error handler of MediaRecorder : [Attachment 352108] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 12 11:04:53 PDT 2018


youenn fablet <youennf at gmail.com> has canceled Wendy <yuhan_wu at apple.com>'s
request for review:
Bug 190438: Implement error handler of MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=190438

Attachment 352108: Patch

https://bugs.webkit.org/attachment.cgi?id=352108&action=review




--- Comment #27 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 352108
  --> https://bugs.webkit.org/attachment.cgi?id=352108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352108&action=review

>
LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-e
rror.html:32
> +	       assert_equals(mediaRecorderErrorEvent.error.name,
'UnknownError', 'the type of error should be UnknownError when track has been
added or removed');

Let's add a check to ensure the event is trusted.
Discussing with Chris, it is not clear whether the error event being created is
or not.


More information about the webkit-reviews mailing list