[webkit-reviews] review granted: [Bug 190321] Cache API tests are flaky due to file writing failing from time to time : [Attachment 351831] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 12 10:19:27 PDT 2018


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 190321: Cache API tests are flaky due to file writing failing from time to
time
https://bugs.webkit.org/show_bug.cgi?id=190321

Attachment 351831: Patch

https://bugs.webkit.org/attachment.cgi?id=351831&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 351831
  --> https://bugs.webkit.org/attachment.cgi?id=351831
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351831&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:508
> +	       callback(Error::WriteDisk);

DiskWrite would look better IMO.


More information about the webkit-reviews mailing list