[webkit-reviews] review granted: [Bug 190517] [PSON] Prewarm system fallback fonts : [Attachment 352165] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 12 10:09:22 PDT 2018
Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 190517: [PSON] Prewarm system fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=190517
Attachment 352165: patch
https://bugs.webkit.org/attachment.cgi?id=352165&action=review
--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 352165
--> https://bugs.webkit.org/attachment.cgi?id=352165
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=352165&action=review
> Source/WebCore/page/ProcessWarming.cpp:93
> + prewarmInformation.fontCache =
FontCache::singleton().collectPrewarmInformation();
> + return prewarmInformation;
Can't we just do this?:
return { FontCache::singleton().collectPrewarmInformation() };
> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1538
> + if (prewarmInformation.seenFamilies.isEmpty() &&
prewarmInformation.fontNamesRequiringSystemFallback.isEmpty())
Maybe we can add PrewarmInformation::isEmpty?
More information about the webkit-reviews
mailing list