[webkit-reviews] review granted: [Bug 190502] [MediaStream] Clean up capture source factory management : [Attachment 352113] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 190502: [MediaStream] Clean up capture source factory management
https://bugs.webkit.org/show_bug.cgi?id=190502

Attachment 352113: Patch

https://bugs.webkit.org/attachment.cgi?id=352113&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 352113
  --> https://bugs.webkit.org/attachment.cgi?id=352113
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352113&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:336
> +static AudioCaptureFactory* audioFactoryOverride;

Maybe this should be a member of RealtimeMediaSourceCenter and we would access
to it through RealtimeMediaSourceCenter::singleton()
Ditto for video capture factory.

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:341
> +void RealtimeMediaSourceCenter::unsetAudioFactory(AudioCaptureFactory&)

Should we remove this parameter or do something like 
ASSERT(audioFactoryOverride == unsetAudioFactory)?
Ditto below.