[webkit-reviews] review granted: [Bug 190510] Web Inspector: Dark Mode: Highlight text in Network Headers search is too dark : [Attachment 352129] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 190510: Web Inspector: Dark Mode: Highlight text in Network Headers search
is too dark
https://bugs.webkit.org/show_bug.cgi?id=190510

Attachment 352129: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=352129&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 352129
  --> https://bugs.webkit.org/attachment.cgi?id=352129
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=352129&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.css:82
> +    color: var(--text-color);

It seems weird to me that we'd color the header keys too (instead of using the
existing current color) , but I suppose that blue-on-yellow isn't much better
:|

If we did, you could drop this `color` altogether, since the `.value` already
uses `--text-color`.