[webkit-reviews] review granted: [Bug 190503] Use currentStackPointer more : [Attachment 352115] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 18:19:03 PDT 2018


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 190503: Use currentStackPointer more
https://bugs.webkit.org/show_bug.cgi?id=190503

Attachment 352115: Patch

https://bugs.webkit.org/attachment.cgi?id=352115&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 352115
  --> https://bugs.webkit.org/attachment.cgi?id=352115
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352115&action=review

> Source/WTF/wtf/StackBounds.cpp:55
> +    volatile uint8_t* stackValue =
bitwise_cast<uint8_t*>(currentStackPointer());

Does this work on debug builds where this is an actual function call?


More information about the webkit-reviews mailing list