[webkit-reviews] review granted: [Bug 189091] Flaky IntersectionObserver web platform tests involving style updates : [Attachment 351259] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 16:33:40 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 189091: Flaky IntersectionObserver web platform tests involving style
updates
https://bugs.webkit.org/show_bug.cgi?id=189091

Attachment 351259: Patch

https://bugs.webkit.org/attachment.cgi?id=351259&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 351259
  --> https://bugs.webkit.org/attachment.cgi?id=351259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351259&action=review

> Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.cpp:258
> +#if ENABLE(INTERSECTION_OBSERVER)
> +	   m_webPage.updateIntersectionObservations();
> +#endif

Would be nice to add a "willDisplayPage" bottleneck to WebPage and/or Page and
move the #ifdef lower down.


More information about the webkit-reviews mailing list