[webkit-reviews] review granted: [Bug 189624] [IntersectionObserver] Handle zero-area intersections : [Attachment 351522] Patch (depends on bug 189833)

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 189624: [IntersectionObserver] Handle zero-area intersections
https://bugs.webkit.org/show_bug.cgi?id=189624

Attachment 351522: Patch (depends on bug 189833)

https://bugs.webkit.org/attachment.cgi?id=351522&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 351522
  --> https://bugs.webkit.org/attachment.cgi?id=351522
Patch (depends on bug 189833)

View in context: https://bugs.webkit.org/attachment.cgi?id=351522&action=review

> Source/WebCore/dom/Document.cpp:7521
> +    bool isIntersecting;

Initialize isIntersecting with { false }?

> Source/WebCore/dom/Document.cpp:7524
> +static std::optional<IntersectionObservationState>
computeIntersectionState(FrameView& frameView, IntersectionObserver& observer,
Element& target)

Can observer be a const&?