[webkit-reviews] review granted: [Bug 190269] IOS 12 - Service worker cache not shared when added to homescreen : [Attachment 352051] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 16:18:13 PDT 2018


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 190269: IOS 12 - Service worker cache not shared when added to homescreen
https://bugs.webkit.org/show_bug.cgi?id=190269

Attachment 352051: Patch

https://bugs.webkit.org/attachment.cgi?id=352051&action=review




--- Comment #20 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 352051
  --> https://bugs.webkit.org/attachment.cgi?id=352051
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352051&action=review

> Source/WebKit/UIProcess/API/APIWebsiteDataStore.cpp:57
> +    auto& store = globalDefaultDataStore();
> +    if (!store)
> +	   return;
> +    store = nullptr;

This could just be replaced by one line:
globalDefaultDataStore() = nullptr;


More information about the webkit-reviews mailing list