[webkit-reviews] review granted: [Bug 190495] Hardware keyboard arrow keys/spacebar don't scroll PDFs (works for web content) : [Attachment 352092] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 11 15:38:11 PDT 2018
Andy Estes <aestes at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 190495: Hardware keyboard arrow keys/spacebar don't scroll PDFs (works for
web content)
https://bugs.webkit.org/show_bug.cgi?id=190495
Attachment 352092: Patch
https://bugs.webkit.org/attachment.cgi?id=352092&action=review
--- Comment #5 from Andy Estes <aestes at apple.com> ---
Comment on attachment 352092
--> https://bugs.webkit.org/attachment.cgi?id=352092
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=352092&action=review
> Source/WebKit/UIProcess/ios/WKPDFView.mm:85
> + ::WebEvent *webEvent = [[[WKWebEvent alloc] initWithEvent:event]
autorelease];
auto webEvent = adoptNS(...?
More information about the webkit-reviews
mailing list