[webkit-reviews] review granted: [Bug 190467] Use finer grained locking in FontDatabase : [Attachment 352038] patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 190467: Use finer grained locking in FontDatabase
https://bugs.webkit.org/show_bug.cgi?id=190467

Attachment 352038: patch

https://bugs.webkit.org/attachment.cgi?id=352038&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 352038
  --> https://bugs.webkit.org/attachment.cgi?id=352038
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352038&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-893
> -	   std::lock_guard<Lock> locker(m_descriptorMapLock);
> -
>	   auto folded = familyName.foldCase();
> -	   return m_familyNameToFontDescriptors.ensure(folded, [&] {

Wouldn't moving the lock_guard to after the call to foldCase have the same
result?  we could leave the call to ensure as it is.