[webkit-reviews] review granted: [Bug 190405] Changes towards allowing use of the ASAN detect_stack_use_after_return option. : [Attachment 352022] proposed patch.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 190405: Changes towards allowing use of the ASAN
detect_stack_use_after_return option.
https://bugs.webkit.org/show_bug.cgi?id=190405

Attachment 352022: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=352022&action=review




--- Comment #6 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 352022
  --> https://bugs.webkit.org/attachment.cgi?id=352022
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=352022&action=review

r=me

> Source/WTF/wtf/StackPointer.cpp:39
> +    // Make sure that sp is the only local variable decalred in this
function.

*declared*

> Source/WTF/wtf/StackPointer.cpp:40
> +    void* sp = reinterpret_cast<uint8_t*>(&sp) + sizeOfFrameHeader +
sizeof(sp);

uint8_t should probably be a uintptr_t.

> Source/WTF/wtf/StackPointer.h:30
> +WTF_EXPORT_PRIVATE void* currentStackPointer();

Did you consider using inline assembly for architectures we know well?