[webkit-reviews] review denied: [Bug 156271] Web Inspector: CSS autocomplete: suggestion hint should be the most commonly used property and not the alphabetically first one : [Attachment 351706] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 156271: Web Inspector: CSS autocomplete: suggestion hint should be the most
commonly used property and not the alphabetically first one
https://bugs.webkit.org/show_bug.cgi?id=156271

Attachment 351706: Patch

https://bugs.webkit.org/attachment.cgi?id=351706&action=review




--- Comment #6 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 351706
  --> https://bugs.webkit.org/attachment.cgi?id=351706
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351706&action=review

There are at least two approaches:

1. According to
https://developer.microsoft.com/en-us/microsoft-edge/platform/tusage/Define,
there are a lot of properties that are almost never used. We can provide a good
experience out of the box if we store property name weights based on public
data.

2. Web Inspector can remember (in localStorage) properties that are used the
most and suggest them.

Doing either of these would be a big improvement. Ideally, I want to have both.

r- until we agree what we want to do here.


> Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:425
> +WI.CSSProperty._nameCount = {};

Does this get lost after closing Web Inspector? We need to save this in
localStorage.