[webkit-reviews] review denied: [Bug 190454] Add an SPI for WebView clients to control the WebKit image format whitelist : [Attachment 352007] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 190454: Add an SPI for WebView clients to control the WebKit image format
whitelist
https://bugs.webkit.org/show_bug.cgi?id=190454

Attachment 352007: Patch

https://bugs.webkit.org/attachment.cgi?id=352007&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 352007
  --> https://bugs.webkit.org/attachment.cgi?id=352007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352007&action=review

This doesn't seem like the right approach.

> Source/WebCore/page/Settings.yaml:587
> +imageFormatWhitelist:
> +    type: String
> +    defaultValue: defaultImageFormatWhitelist()

It's not clear to me that the whitelist should be a setting.

> Source/WebCore/platform/graphics/Image.h:203
> +    String m_imageFormatWhitelist;

Why does every image have to store the whitelist? The whitelist should live in
some object that gets consulted (next to MimeTypeRegistery or something).