[webkit-reviews] review canceled: [Bug 190438] Implement error handler of MediaRecorder : [Attachment 351991] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has canceled Wendy <yuhan_wu at apple.com>'s
request for review:
Bug 190438: Implement error handler of MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=190438

Attachment 351991: Patch

https://bugs.webkit.org/attachment.cgi?id=351991&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 351991
  --> https://bugs.webkit.org/attachment.cgi?id=351991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351991&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:79
> +	   dispatchEvent(Event::create(eventNames().errorEvent,
Event::CanBubble::No, Event::IsCancelable::No));

It should probably be asynchronous and dispatch a MediaRecorderErrorEvent.
Spec is unclear though. I filed
https://github.com/w3c/mediacapture-record/issues/151.
In the meantime, dispatching Unknown exception might be good enough.

> Source/WebCore/Modules/mediarecorder/MediaRecorder.h:36
> +class MediaRecorder final : public ActiveDOMObject, public
RefCounted<MediaRecorder>, public EventTargetWithInlineData, public
MediaStream::Observer {

Can you make it private MediaStream::Observer?

> Source/WebCore/Modules/mediarecorder/MediaRecorder.h:74
> +    void didAddOrRemoveTrack();

final