[webkit-reviews] review granted: [Bug 190362] Web Inspector: REGRESSION: selection in network table is lost when new entries are added : [Attachment 351975] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 10 13:25:12 PDT 2018


Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 190362: Web Inspector: REGRESSION: selection in network table is lost when
new entries are added
https://bugs.webkit.org/show_bug.cgi?id=190362

Attachment 351975: Patch

https://bugs.webkit.org/attachment.cgi?id=351975&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 351975
  --> https://bugs.webkit.org/attachment.cgi?id=351975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351975&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Table.js:241
> +	   this._selectedRowIndex = NaN;

Oops, good catch!


More information about the webkit-reviews mailing list