[webkit-reviews] review granted: [Bug 190420] Share more WKShareSheet code between macOS and iOS, and fix a few bugs : [Attachment 351948] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 10 11:25:02 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 190420: Share more WKShareSheet code between macOS and iOS, and fix a few
bugs
https://bugs.webkit.org/show_bug.cgi?id=190420

Attachment 351948: Patch

https://bugs.webkit.org/attachment.cgi?id=351948&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 351948
  --> https://bugs.webkit.org/attachment.cgi?id=351948
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351948&action=review

> Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:79
> +	   NSURL *url = (NSURL *)*data.url;

I think I prefer data.url.value() to avoid too many splats.


More information about the webkit-reviews mailing list