[webkit-reviews] review granted: [Bug 190419] Performance dashboard should show added iterations due failed build requests. : [Attachment 351929] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 9 20:08:30 PDT 2018
Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 190419: Performance dashboard should show added iterations due failed build
requests.
https://bugs.webkit.org/show_bug.cgi?id=190419
Attachment 351929: Patch
https://bugs.webkit.org/attachment.cgi?id=351929&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 351929
--> https://bugs.webkit.org/attachment.cgi?id=351929
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=351929&action=review
> Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:374
> + this.content('status-summary').innerHTML =
`${currentGroup.initialRepetitionCount()} requested,
${currentGroup.repetitionCount() - currentGroup.initialRepetitionCount()} added
due to failures.`;
Let's store values in local variables first so that the template literal looks
nicer.
More information about the webkit-reviews
mailing list