[webkit-reviews] review granted: [Bug 190403] Web Inspector: REGRESSION: fix canvas test failures after r236952 and r236954 : [Attachment 351888] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 9 10:40:04 PDT 2018
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 190403: Web Inspector: REGRESSION: fix canvas test failures after r236952
and r236954
https://bugs.webkit.org/show_bug.cgi?id=190403
Attachment 351888: Patch
https://bugs.webkit.org/attachment.cgi?id=351888&action=review
--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 351888
--> https://bugs.webkit.org/attachment.cgi?id=351888
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=351888&action=review
r=me
> LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js:78
> + // This can't use `awaitEvent` since the promise resolution
happens on the next tick.sss
Whats up with the "tick.sss" at the end of this sentence? Just a typo?
More information about the webkit-reviews
mailing list